These forums are archived

See this post for further info

get_iplayer forums

Forum archived. Posting disabled.

patch for 2.94 , remove comments in media headers

user-965

Hi,

I had a failure where this appeared in the HCL stream:

#EXT-X-VERSION:4,
## Created with Unified Streaming Platform(version=1.7.9)


This caused an error at line 7099.

The attached patch(against 2.94) sidesteps this parse noise, although someone who actually knows the source might want a nicer solution.

patch-29JUN2015.txt

user-2

You didn't patch 2.94 (must be an old version), nor do you need to. And FWIW, your patch wouldn't have the desired effect. You only want to skip comments, not exit the function.

EDIT: Remove statement that single hash symbol is comment leader

user-2

My bad: Double hash symbol is indeed the comment leader in these files. However, there may be other commands (begin with single hash symbol) that should also be ignored.

user-965

Empirically it avoided the error, but of course inelegant.

The version was from get_iplayer-2.94-1.1.src.rpm, but I manually built/installed.

Thank you for looking into that.

user-2

Where did you get that RPM? Your patch shows it is missing the fix for this particular problem in 2.94. so something has gone wrong somewhere.

These forums are archived

See this post for further info