get_iplayer forums

patch for 2.94 , remove comments in media headers - Printable Version

+- get_iplayer forums (https://forums.squarepenguin.co.uk)
+-- Forum: Linux & Unix Forums (https://forums.squarepenguin.co.uk/forum-10.html)
+--- Forum: Linux & Unix General Help & Support (https://forums.squarepenguin.co.uk/forum-13.html)
+---- Thread: patch for 2.94 , remove comments in media headers (https://forums.squarepenguin.co.uk/thread-453.html)



patch for 2.94 , remove comments in media headers - fosswizard - 30-06-2015

Hi,

I had a failure where this appeared in the HCL stream:

#EXT-X-VERSION:4,
## Created with Unified Streaming Platform(version=1.7.9)


This caused an error at line 7099.

The attached patch(against 2.94) sidesteps this parse noise, although someone who actually knows the source might want a nicer solution.


patch for 2.94 , remove comments in media headers - dinky - 30-06-2015

You didn't patch 2.94 (must be an old version), nor do you need to. And FWIW, your patch wouldn't have the desired effect. You only want to skip comments, not exit the function.

EDIT: Remove statement that single hash symbol is comment leader


patch for 2.94 , remove comments in media headers - dinky - 30-06-2015

My bad: Double hash symbol is indeed the comment leader in these files. However, there may be other commands (begin with single hash symbol) that should also be ignored.


patch for 2.94 , remove comments in media headers - fosswizard - 30-06-2015

Empirically it avoided the error, but of course inelegant.

The version was from get_iplayer-2.94-1.1.src.rpm, but I manually built/installed.

Thank you for looking into that.


patch for 2.94 , remove comments in media headers - dinky - 30-06-2015

Where did you get that RPM? Your patch shows it is missing the fix for this particular problem in 2.94. so something has gone wrong somewhere.